Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: propagate all the args for edge and update tce/sequencer config #286

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat: propagate all the args for edge and update tce/sequencer config #286

merged 5 commits into from
Aug 29, 2023

Conversation

hadjiszs
Copy link
Member

@hadjiszs hadjiszs commented Aug 24, 2023 •
edited
Loading

Description

  • propagate all the args for Edge
  • moved to kebab-case
  • prune verifier and data-dir for the sequencer configuration which are not useful anymore
  • change default directory for the tce db
  • rename base_tce_api_url to tce-grpc-endpoint
  • renamed the subnet toml profile to edge so that it is explicit that it is about the Edge arguments

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@hadjiszs hadjiszs requested a review from a team as a code owner August 24, 2023 01:09
@hadjiszs hadjiszs changed the title feat: propagate all the args for edge and prune sequencer config feat: propagate all the args for edge and update tce/sequencer config Aug 24, 2023
@hadjiszs hadjiszs requested a review from gruberb August 24, 2023 01:10
@hadjiszs hadjiszs force-pushed the feat/TP-679 branch 2 times, most recently from f6afca0 to 4aa7825 Compare August 24, 2023 02:10
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #286 (471b1d0) into main (bb3e8f7) will increase coverage by 1.35%.
Report is 1 commits behind head on main.
The diff coverage is 61.95%.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   52.00%   53.35%   +1.35%     
==========================================
  Files         214      214              
  Lines       10275    10315      +40     
==========================================
+ Hits         5343     5504     +161     
+ Misses       4932     4811     -121
Files Changed Coverage Δ
crates/topos-sequencer/src/lib.rs 0.00% <0.00%> (ø)
crates/topos/src/components/sequencer/mod.rs 0.00% <0.00%> (ø)
crates/topos/src/components/setup/mod.rs 0.00% <0.00%> (ø)
crates/topos/src/config/base.rs 75.67% <ø> (+8.10%) ⬆️
crates/topos/src/config/edge.rs 81.25% <ø> (-6.75%) ⬇️
crates/topos/src/config/mod.rs 75.75% <0.00%> (-2.37%) ⬇️
crates/topos/src/config/sequencer.rs 0.00% <0.00%> (ø)
crates/topos/src/edge/mod.rs 45.26% <13.33%> (+16.34%) ⬆️
crates/topos/src/components/node/services.rs 20.61% <38.46%> (+6.17%) ⬆️
crates/topos/src/components/node/mod.rs 42.36% <70.00%> (-0.20%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

@hadjiszs hadjiszs force-pushed the feat/TP-679 branch 3 times, most recently from 6a1ca0e to 462a8a9 Compare August 29, 2023 16:04
@hadjiszs hadjiszs merged commit ba49d75 into main Aug 29, 2023
20 of 21 checks passed
@hadjiszs hadjiszs deleted the feat/TP-679 branch August 29, 2023 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@gruberb gruberb gruberb approved these changes

@Freyskeyd Freyskeyd Awaiting requested review from Freyskeyd Freyskeyd is a code owner automatically assigned from topos-protocol/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadjiszs @gruberb @atanmarko